feat: add SetClientRootCertificate method support clientCAs usage #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeevatkm
requested changes
Aug 25, 2024
There was a problem hiding this comment.
@MagHErmit - Thanks for creating a PR for Client CA.
Can you refactor these methods with SetRootCertificate and SetRootCertificateFromString to reduce duplicate code base?
|
@MagHErmit Any update? |
|
@MagHErmit, Are you interested in updating the PR? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #826 +/- ##
==========================================
- Coverage 96.20% 96.09% -0.12%
==========================================
Files 14 14
Lines 1794 1816 +22
==========================================
+ Hits 1726 1745 +19
- Misses 45 47 +2
- Partials 23 24 +1 ☔ View full report in Codecov by Sentry. |
jeevatkm
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
@MagHErmit This time, I will work on PR refactoring; next time, I will need your cooperation when you create a PR.
jeevatkm
added a commit
that referenced
this pull request
Sep 11, 2024
jeevatkm
added a commit
that referenced
this pull request
Sep 11, 2024
renovate bot
referenced
this pull request
in Michsior14/transmission-gluetun-port-update
Sep 15, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/go-resty/resty/v2](https://redirect.github.com/go-resty/resty) | `v2.14.0` -> `v2.15.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>go-resty/resty (github.com/go-resty/resty/v2)</summary> ### [`v2.15.0`](https://redirect.github.com/go-resty/resty/releases/tag/v2.15.0) [Compare Source](https://redirect.github.com/go-resty/resty/compare/v2.14.0...v2.15.0) ### Release Notes #### New Features - feat: add max reponse body limit by [@​trim21](https://redirect.github.com/trim21) in [https://github.com/go-resty/resty/pull/830](https://redirect.github.com/go-resty/resty/pull/830) - feat: add SetClientRootCertificate method support clientCAs usage by [@​MagHErmit](https://redirect.github.com/MagHErmit) in [https://github.com/go-resty/resty/pull/826](https://redirect.github.com/go-resty/resty/pull/826) #### Enhancements - feat: add ability to set custom multipart boundary value by [@​PokeGuys](https://redirect.github.com/PokeGuys) in [https://github.com/go-resty/resty/pull/820](https://redirect.github.com/go-resty/resty/pull/820) - feat(refactor): for pr [#​826](https://redirect.github.com/go-resty/resty/issues/826) by [@​jeevatkm](https://redirect.github.com/jeevatkm) in [https://github.com/go-resty/resty/pull/848](https://redirect.github.com/go-resty/resty/pull/848) #### Bug Fixes - Fix request/response logging for SetDoNotParseResponse(true) by [@​kon3gor](https://redirect.github.com/kon3gor) in [https://github.com/go-resty/resty/pull/836](https://redirect.github.com/go-resty/resty/pull/836) - fix(enhancement): add explicit option to enable generate curl command in conjunction with debug mode and few clean ups [#​828](https://redirect.github.com/go-resty/resty/issues/828) by [@​jeevatkm](https://redirect.github.com/jeevatkm) in [https://github.com/go-resty/resty/pull/842](https://redirect.github.com/go-resty/resty/pull/842) #### Build - feat(enhancement): update bazel config by [@​frank30941](https://redirect.github.com/frank30941) in [https://github.com/go-resty/resty/pull/833](https://redirect.github.com/go-resty/resty/pull/833) - build: go min version and build config update [#​835](https://redirect.github.com/go-resty/resty/issues/835) by [@​jeevatkm](https://redirect.github.com/jeevatkm) in [https://github.com/go-resty/resty/pull/837](https://redirect.github.com/go-resty/resty/pull/837) - Update go vesion to 1.20 by [@​kon3gor](https://redirect.github.com/kon3gor) in [https://github.com/go-resty/resty/pull/841](https://redirect.github.com/go-resty/resty/pull/841) #### Documentation - doc: godoc improvements and corrections by [@​jeevatkm](https://redirect.github.com/jeevatkm) in [https://github.com/go-resty/resty/pull/849](https://redirect.github.com/go-resty/resty/pull/849), [https://github.com/go-resty/resty/pull/851](https://redirect.github.com/go-resty/resty/pull/851) - doc(readme): Add a note, GenerateCurlCommand by [@​ahuigo](https://redirect.github.com/ahuigo) in [https://github.com/go-resty/resty/pull/817](https://redirect.github.com/go-resty/resty/pull/817) - release: version bump and readme update for v2.15.0 by [@​jeevatkm](https://redirect.github.com/jeevatkm) in [https://github.com/go-resty/resty/pull/852](https://redirect.github.com/go-resty/resty/pull/852) #### New Contributors - [@​PokeGuys](https://redirect.github.com/PokeGuys) made their first contribution in [https://github.com/go-resty/resty/pull/820](https://redirect.github.com/go-resty/resty/pull/820) - [@​trim21](https://redirect.github.com/trim21) made their first contribution in [https://github.com/go-resty/resty/pull/830](https://redirect.github.com/go-resty/resty/pull/830) - [@​frank30941](https://redirect.github.com/frank30941) made their first contribution in [https://github.com/go-resty/resty/pull/833](https://redirect.github.com/go-resty/resty/pull/833) - [@​kon3gor](https://redirect.github.com/kon3gor) made their first contribution in [https://github.com/go-resty/resty/pull/841](https://redirect.github.com/go-resty/resty/pull/841) - [@​MagHErmit](https://redirect.github.com/MagHErmit) made their first contribution in [https://github.com/go-resty/resty/pull/826](https://redirect.github.com/go-resty/resty/pull/826) **Full Changelog**: go-resty/resty@v2.14.0...v2.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/Michsior14/transmission-gluetun-port-update). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43NC4xIiwidXBkYXRlZEluVmVyIjoiMzguNzQuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support setting custom clientCAs cert